Libuv Asys Implementation - #1022
Draft
Aidan63 wants to merge 164 commits into
Draft
Conversation
12 tasks
cstdint should be auto imported through hxcpp.h, but gcc fails at the enums
This reverts commit 179ce1c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP Libuv based asys api implementation. Trying to hide the libuv-ness behind a generic asys header so someone could provide an alternative asys implementation for platforms which might not support libuv but have their own. Also going to add a "NotImplementedException" asys implementation for non desktop platforms.
I've tried a base object approach instead of differing implementations behind #ifdef checks so typed objects can be passed around instead of Dynamic. I'm also using some c++ 14 features (make_unique and nested namespaces), not sure if there's a c++ version that hxcpp tries to target. I'm not married to any of this so I'm happy to change any of it.
Other TODO:
uv_handle_t's are cleaned up when things fail (look into customunique_ptr's to automate this)hx::Throwas no-return.